Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more msg when exec probe timeout #106201

Merged
merged 1 commit into from Nov 16, 2021
Merged

Add more msg when exec probe timeout #106201

merged 1 commit into from Nov 16, 2021

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Nov 6, 2021 •
edited by k8s-ci-robot

Signed-off-by: yxxhero aiopsclub@163.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

add more msg when exec probe timeout

Which issue(s) this PR fixes:

Fixes #106111

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Enhanced event messages for pod failed for exec probe timeout

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@yxxhero
add more msg when exec probe timeout
4211826 
Signed-off-by: yxxhero <aiopsclub@163.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Nov 6, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Nov 6, 2021

/kind bug

@yxxhero
Copy link
Member Author

yxxhero commented Nov 6, 2021

/cc @ehashman @pacoxu @mengjiao-liu

@yxxhero yxxhero changed the title add more msg when exec probe timeout Add more msg when exec probe timeout Nov 6, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Nov 8, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021

/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 8, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021 •
edited

/lgtm
It makes sense.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

Add more messages for failing event when exec probe timeout
failure event of timeout
Add more information for exec probe event failures due to timeout

/lgtm
It makes sense.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021

/release-note-edit

Enhanced event messages for pod failed for exec probe timeout

@pacoxu pacoxu added this to Needs Approver in SIG Node PR Triage Nov 8, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2021
@s-kawamura-w664
Copy link

Look good to me too.

@s-kawamura-w664
Copy link

/cc

@yxxhero
Copy link
Member Author

yxxhero commented Nov 8, 2021

/cc

Do you have any suggestions? Thanks very much.

@s-kawamura-w664
Copy link

/cc

Do you have any suggestions? Thanks very much.

No. My remindar only. Thank you very much.

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yxxhero
Copy link
Member Author

yxxhero commented Nov 8, 2021

/assign @yujuhong

@mengjiao-liu
Copy link
Member

/lgtm

@yxxhero yxxhero mentioned this pull request Nov 13, 2021
Closed
7 tasks
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 39af75a into kubernetes:master Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

@ehashman ehashman Awaiting requested review from ehashman

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@pacoxu pacoxu Awaiting requested review from pacoxu

@s-kawamura-w664 s-kawamura-w664 Awaiting requested review from s-kawamura-w664

Assignees

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

@yujuhong yujuhong

@mengjiao-liu mengjiao-liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Liveness/Readiness probe timed out but no reason found in pod describe events
8 participants
@yxxhero @k8s-ci-robot @pacoxu @s-kawamura-w664 @mengjiao-liu @mrunalp @SergeyKanzhelev @yujuhong