[go1.17] Update to go1.17.2 #105563
Merged
[go1.17] Update to go1.17.2 #105563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/release-eng
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
|
PR kubernetes/release#2285 is merged. |
mengjiao-liu
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
watch release images https://prow.k8s.io/?type=postsubmit |
k8s-ci-robot
added
the
sig/api-machinery
|
/assign @dims @liggitt @justaugustus |
saschagrunert
approved these changes
Oct 14, 2021
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, mengjiao-liu, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
Shouldn't this change be reflected in go.mod file (which still lists go1.16)? |
no. switching the go.mod file to go1.17 has other implications we don't want (it denormalizes all transitive dependencies into the root go.mod file in ways that disrupt our dependency checking tools) |
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Dec 28, 2021
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
marwanad
pushed a commit
to marwanad/autoscaler
that referenced
this pull request
Jan 3, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Jan 10, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Jan 12, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Jan 17, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Jan 18, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
MaxRink
pushed a commit
to MaxRink/autoscaler
that referenced
this pull request
Feb 14, 2022
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area dependency release-eng security
What this PR does / why we need it:
Which issue(s) this PR fixes:
Ref kubernetes/release#2254
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: