Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention seccomp annotation removal in v1.25 #104389

Merged
merged 1 commit into from Aug 16, 2021
Merged

Mention seccomp annotation removal in v1.25 #104389

merged 1 commit into from Aug 16, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 16, 2021 •
edited by liggitt

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This patch adds removal warnings for the deprecated seccomp annotation, which is targeting removal in v1.25.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to kubernetes/enhancements#135 (comment)

Does this PR introduce a user-facing change?

Action required: support for the seccomp annotations `seccomp.security.alpha.kubernetes.io/pod` and `container.seccomp.security.alpha.kubernetes.io/[name]`, deprecated since 1.19, will be dropped in 1.25. Transition to using the `seccompProfile` API field.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/blob/cccc6fa/keps/sig-node/135-seccomp/README.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2021
@saschagrunert
Copy link
Member Author

/sig node
/priority important-soon

PTAL @kubernetes/api-reviewers @pjbgf @tallclair

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2021
@saschagrunert saschagrunert changed the title Mention seccomp annotation removal in v1.26 Mention seccomp annotation removal in v1.25 Aug 16, 2021
@saschagrunert saschagrunert force-pushed the seccomp-annotation-removal branch 2 times, most recently from 19813a2 to 621e022 Compare August 16, 2021 10:38
pjbgf
pjbgf approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
liggitt
liggitt reviewed Aug 16, 2021
View reviewed changes
pkg/api/pod/warnings.go Outdated Show resolved Hide resolved
@saschagrunert
Mention seccomp annotation removal in v1.25
cdbfd00 
This patch adds removal warnings for the deprecated seccomp annotation,
which is targeting removal in v1.25.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Aug 16, 2021

/approve

@liggitt
Copy link
Member

liggitt commented Aug 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pjbgf, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 74a09fe into kubernetes:master Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 16, 2021
@liggitt liggitt added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2021
@saschagrunert saschagrunert deleted the seccomp-annotation-removal branch August 17, 2021 07:23
@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2021

The generated changelog is not correct in https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.23.md#no-really-you-must-read-this-before-you-upgrade.

Not sure why.

@rfranzke rfranzke mentioned this pull request Jan 12, 2022
Closed
20 tasks
@liggitt liggitt mentioned this pull request May 9, 2022
Merged
OysteinThuen added a commit to 3lvia/kubernetes-charts that referenced this pull request May 17, 2022
@OysteinThuen
Fix seccompProfile to new format using securityContext
bfc8256 
kubernetes/kubernetes#104389
@OysteinThuen OysteinThuen mentioned this pull request May 17, 2022
Merged
OysteinThuen added a commit to 3lvia/kubernetes-charts that referenced this pull request May 18, 2022
@OysteinThuen
Fix seccompProfile to new format using securityContext (#32)
d8fe5ba 
kubernetes/kubernetes#104389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@pjbgf pjbgf pjbgf approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@pjbgf pjbgf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saschagrunert @k8s-ci-robot @liggitt @pacoxu @pjbgf