Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated scheduler files preemption.go, stateful.go, resource_allocation.go to structured logging #105967

Merged
merged 1 commit into from Nov 9, 2021
Merged

Migrated scheduler files preemption.go, stateful.go, resource_allocation.go to structured logging #105967

merged 1 commit into from Nov 9, 2021

Conversation

shiva1333
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrated pkg/scheduler/framework/preemption/preemption.go, pkg/scheduler/framework/plugins/examples/stateful/stateful.go, and pkg/scheduler/framework/plugins/noderesources/resource_allocation.go to structured logging

Which issue(s) this PR fixes:

Ref #105841

Special notes for your reviewer:

Added missing migration points, fixed previously migrated logs

Does this PR introduce a user-facing change?

Migrated `pkg/scheduler/framework/preemption/preemption.go`, `pkg/scheduler/framework/plugins/examples/stateful/stateful.go`, and `pkg/scheduler/framework/plugins/noderesources/resource_allocation.go` to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 28, 2021
@shiva1333
Copy link
Contributor Author

/sig instrumentation
/wg structured-logging
/area logging
/priority important-soon
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 28, 2021
@shiva1333 shiva1333 added this to Waiting on Reviewer in WG Structured Logging - 1.23 Migration Oct 28, 2021
@shiva1333
Copy link
Contributor Author

/test pull-kubernetes-verify

@jyz0309 jyz0309 mentioned this pull request Oct 28, 2021
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@shiva1333
Copy link
Contributor Author

/retest

@ehashman ehashman added this to Triage in SIG Node PR Triage Nov 1, 2021
@Huang-Wei
Copy link
Member

/lgtm
/approve

@wgahnagl wgahnagl moved this from Triage to Needs Approver in SIG Node PR Triage Nov 3, 2021
@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2021
@serathius
Copy link
Contributor

/assign @mrunalp

@serathius
Copy link
Contributor

This PR is needed to finish scheduler structured logging migration planned for 1.23
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@shiva1333
Copy link
Contributor Author

required for 1.23
ping @mrunalp for approval

yangjunmyfm192085
yangjunmyfm192085 reviewed Nov 9, 2021
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@shiva1333
Copy link
Contributor Author

/assign @sjenning for approval

@k8s-ci-robot
Copy link
Contributor

@shivanshu1333: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sjenning for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
pohly
pohly approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, mrunalp, pohly, shivanshu1333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor

pohly commented Nov 9, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6ac2d8e into kubernetes:master Nov 9, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 9, 2021
WG Structured Logging - 1.23 Migration automation moved this from Needs Approval to Done Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchan pchan pchan left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@serathius serathius serathius left review comments

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@pohly pohly pohly approved these changes

@mrunalp mrunalp mrunalp approved these changes

@chendave chendave Awaiting requested review from chendave

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@pohly pohly

@mrunalp mrunalp

@sjenning sjenning

@Huang-Wei Huang-Wei

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Node PR Triage
Done
WG Structured Logging - 1.23 Migration
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet