Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase Azure ACR credential provider timeout #108209

Merged
merged 1 commit into from Feb 18, 2022
Merged

increase Azure ACR credential provider timeout #108209

merged 1 commit into from Feb 18, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

increase Azure ACR credential provider timeout
from 1.22, connection timeout to ACR is set as 10s, which in some cases, 10s is not enough, would cause following timeout:

Feb 16 10:05:09 aks-pdweappool02-29359546-vmss000002 kubelet[28475]: E0216 10:05:09.652945   28475 azure_credentials.go:326] failed to receive challenge: error reaching registry endpoint https://xxx.azurecr.io/v2/, error: Get "https://xxx.azurecr.io/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)Feb 16 10:05:09 aks-pdweappool02-29359546-vmss000002 kubelet[28475]: E0216 10:05:09.652966   28475 azure_credentials.go:264] error getting credentials from ACR for xxx.azurecr.io error reaching registry endpoint https://xxx.azurecr.io/v2/, error: Get "https://xxx.azurecr.io/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

This PR increases timeout from 10s to 60s

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

increase Azure ACR credential provider timeout

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

increase Azure ACR credential provider timeout

/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2022
feiskyer
feiskyer approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-azure-file-vmss 3867b3e link false /test pull-kubernetes-e2e-capz-azure-file-vmss
pull-kubernetes-e2e-capz-azure-disk-vmss 3867b3e link false /test pull-kubernetes-e2e-capz-azure-disk-vmss
pull-kubernetes-e2e-capz-azure-file 3867b3e link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-capz-azure-disk 3867b3e link false /test pull-kubernetes-e2e-capz-azure-disk

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 2355747 into kubernetes:master Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 18, 2022
andrewsykim
andrewsykim reviewed Feb 18, 2022
View reviewed changes
pkg/credentialprovider/azure/azure_acr_helper.go
@@ -81,7 +81,7 @@ const dockerTokenLoginUsernameGUID = "00000000-0000-0000-0000-000000000000"

var client = &http.Client{
Transport: utilnet.SetTransportDefaults(&http.Transport{}),
Timeout: time.Second * 10,
Timeout: time.Second * 60,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a retry might be more appropriate than increasing the timeout since this could be on the hot path for pod startup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really hit this issue, and image pulling would retry if image pulling failed, while it never succeeded with 10s timeout. And set as 60s really solved the issue.

This was referenced Feb 20, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 3, 2022
@k8s-ci-robot
Merge pull request #108227 from andyzhangx/automated-cherry-pick-of-#…
71b6857 
…108209-upstream-release-1.22

Automated cherry pick of #108209: increase Azure ACR credential provider timeout
k8s-ci-robot added a commit that referenced this pull request Mar 3, 2022
@k8s-ci-robot
Merge pull request #108226 from andyzhangx/automated-cherry-pick-of-#…
3826453 
…108209-upstream-release-1.23

Automated cherry pick of #108209: increase Azure ACR credential provider timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@feiskyer feiskyer feiskyer approved these changes

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @k8s-ci-robot @feiskyer @andrewsykim