Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VolumeSubpath feature gate back in preparation for its removal #105474

Merged
merged 1 commit into from Oct 14, 2021
Merged

Add VolumeSubpath feature gate back in preparation for its removal #105474

merged 1 commit into from Oct 14, 2021

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Oct 4, 2021 •
edited

What type of PR is this?

/kind deprecation
/sig storage

What this PR does / why we need it:

Followup of #105090, in preparation for the deprecation notice of the VolumeSubpath feature gate we're still going to keep it but locked to its default value of true and add a notice that it'll be removed in a couple of releases from now.

Feature-gate VolumeSubpath has been deprecated and cannot be disabled. It will be completely removed in 1.25

/assign @saad-ali

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

@mauriciopoppe: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

@mauriciopoppe: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 4, 2021
@mauriciopoppe
Copy link
Member Author

/cc @msau42

@mauriciopoppe
Copy link
Member Author

/uncc @brendanburns @dchen1107
/cc @thockin

@k8s-ci-robot k8s-ci-robot requested review from thockin and removed request for dchen1107 October 4, 2021 22:30
@mauriciopoppe mauriciopoppe changed the title Add VolumeSubpath feature back in preparation for its deprecation Add VolumeSubpath feature gate back in preparation for its deprecation Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 4, 2021
@saad-ali saad-ali mentioned this pull request Oct 4, 2021
Merged
saad-ali
saad-ali approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/features/kube_features.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 4, 2021
@mauriciopoppe mauriciopoppe changed the title Add VolumeSubpath feature gate back in preparation for its deprecation Add VolumeSubpath feature gate back in preparation for its removal Oct 4, 2021
@mauriciopoppe mauriciopoppe deleted the readd-volume-subpath-flag branch October 5, 2021 21:22
@mauriciopoppe mauriciopoppe restored the readd-volume-subpath-flag branch October 5, 2021 22:52
@mauriciopoppe mauriciopoppe reopened this Oct 5, 2021
@mauriciopoppe mauriciopoppe force-pushed the readd-volume-subpath-flag branch 2 times, most recently from a7fd86a to acad5ea Compare October 5, 2021 22:56
@mauriciopoppe
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@mauriciopoppe
Copy link
Member Author

hey @thockin, we're trying to keep the VolumeSubpath feature gate code in preparation for its removal in 1.25, could you review this PR please? thanks

/assign @thockin

@msau42
Copy link
Member

msau42 commented Oct 13, 2021

In the release note, instead of "no longer enforced" can you change it to "cannot be disabled"?

@mauriciopoppe
Copy link
Member Author

@msau42 release note updated

thockin
thockin reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@msau42 has final LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe, saad-ali, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42
Copy link
Member

msau42 commented Oct 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit a8bda48 into kubernetes:master Oct 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 14, 2021
@sftim sftim mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali saad-ali approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@thockin thockin

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mauriciopoppe @k8s-ci-robot @msau42 @k8s-triage-robot @thockin @saad-ali