Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kubeadm): remove the flag --port from KCM manifest #104157

Merged
merged 1 commit into from Aug 5, 2021
Merged

refactor(kubeadm): remove the flag --port from KCM manifest #104157

merged 1 commit into from Aug 5, 2021

Conversation

knight42
Copy link
Member

@knight42 knight42 commented Aug 5, 2021 •
edited

Signed-off-by: Jian Zeng zengjian.zj@bytedance.com

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Remove the deprecated flag --port from the kubeadm manifest of kube-controller-manager.

Which issue(s) this PR fixes:

Part of kubernetes/kubeadm#2207

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: remove the --port flag from the manifest for the kube-controller-manager since the flag has been a NO-OP since 1.22 and insecure serving was removed for the component.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@knight42
refactor(kubeadm): remove the flag --port from KCM manifest
c486b22 
Signed-off-by: Jian Zeng <zengjian.zj@bytedance.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 5, 2021
@knight42
Copy link
Member Author

knight42 commented Aug 5, 2021

/assign @neolit123
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2021
@neolit123
Copy link
Member

thanks @knight42
this seems correct to me given you did #96216 in 1.22.

we should add a release note here:

kubeadm: remove the --port flag from the manifest for the kube-controller-manager since the flag has been a NO-OP since 1.22 and insecure serving was removed for the component.

@neolit123
Copy link
Member

/approve
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knight42, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
neolit123
neolit123 reviewed Aug 5, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@knight42 you cancel the hold once you add the release note.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 5, 2021
@knight42
Copy link
Member Author

knight42 commented Aug 5, 2021

@neolit123 The release note has been added now.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2021
@neolit123
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5eeaafd into kubernetes:master Aug 5, 2021
@knight42 knight42 deleted the remove-port-from-kubeadm-manifest branch August 10, 2021 07:22
@neolit123 neolit123 mentioned this pull request Aug 31, 2021
Closed
@liggitt liggitt removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knight42 @neolit123 @k8s-ci-robot @liggitt