Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set AllowLongNodeID to true by default since 1.23 #104160

Merged
merged 1 commit into from Aug 30, 2021
Merged

set AllowLongNodeID to true by default since 1.23 #104160

merged 1 commit into from Aug 30, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 5, 2021 •
edited by liggitt

What type of PR is this?

follow up of #98753 to fix #99981

/kind cleanup
/sig storage
/assign @Jiawei0227

The maximum length of the CSINode id field has increased to 256 bytes to match the CSI spec

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2021
liggitt
liggitt reviewed Aug 25, 2021
View reviewed changes
pkg/registry/storage/csinode/strategy.go Outdated
Comment on lines 80 to 81
// in 1.22 on update, set AllowLongNodeID to true only if the old object already has a long node ID
// in 1.23 on update, set AllowLongNodeID=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop these comments now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

liggitt
liggitt reviewed Aug 25, 2021
View reviewed changes
pkg/registry/storage/csinode/strategy.go Outdated
Comment on lines 51 to 52
// in 1.22, on create, set AllowLongNodeID=false
// in 1.23, on create, set AllowLongNodeID=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop these comments now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@liggitt liggitt mentioned this pull request Aug 25, 2021
Closed
@Jiawei0227
Copy link
Contributor

Hey @pacoxu thanks for the PR! Can you change the release note to
192 bytes to 256 bytes

@pacoxu
Copy link
Member Author

pacoxu commented Aug 26, 2021

Hey @pacoxu thanks for the PR! Can you change the release note to
192 bytes to 256 bytes

Updated. Thanks.

@Jiawei0227
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@liggitt
Copy link
Member

liggitt commented Aug 30, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit d5cf549 into kubernetes:master Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@pacoxu pacoxu deleted the AllowLongNodeID-true branch May 10, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees

@Jiawei0227 Jiawei0227

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Relax CSI Node length limitation in 1.22
4 participants
@pacoxu @k8s-ci-robot @Jiawei0227 @liggitt