Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScoringStrategy RequestedToCapacityRatio's shape should not be empty #106169

Merged
merged 1 commit into from Nov 11, 2021
Merged

ScoringStrategy RequestedToCapacityRatio's shape should not be empty #106169

merged 1 commit into from Nov 11, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Nov 5, 2021

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

when we choose using RequestedToCapacityRatio ScoringStrategy, shape of UtilizationShapePoint should not be empty.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

When using `RequestedToCapacityRatio` ScoringStrategy, empty shape will cause error.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@kerthcet
fix RequestedToCapacityRatioParam's shape can be empty
371eb83 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2021
kerthcet
kerthcet commented Nov 5, 2021
View reviewed changes
pkg/scheduler/apis/config/validation/validation_pluginargs.go
@@ -306,7 +306,7 @@ func ValidateNodeResourcesFitArgs(path *field.Path, args *config.NodeResourcesFi

if args.ScoringStrategy != nil {
allErrs = append(allErrs, validateResources(args.ScoringStrategy.Resources, path.Child("resources"))...)
if args.ScoringStrategy.RequestedToCapacityRatio != nil && len(args.ScoringStrategy.RequestedToCapacityRatio.Shape) > 0 {
if args.ScoringStrategy.RequestedToCapacityRatio != nil {
Copy link
Member Author

@kerthcet kerthcet Nov 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error will append here.

@kerthcet
Copy link
Member Author

kerthcet commented Nov 5, 2021

/sig scheduling

@kerthcet
Copy link
Member Author

kerthcet commented Nov 5, 2021

/remove-kind api-change

@k8s-ci-robot k8s-ci-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 5, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Nov 6, 2021

/retitle ScoringStrategy RequestedToCapacityRatio's shape should not be empty

@k8s-ci-robot k8s-ci-robot changed the title fix RequestedToCapacityRatioParam's shape can be empty ScoringStrategy RequestedToCapacityRatio's shape should not be empty Nov 6, 2021
@kerthcet
Copy link
Member Author

/cc @ahg-g

@ahg-g
Copy link
Member

ahg-g commented Nov 11, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit d9f06f9 into kubernetes:master Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 11, 2021
@kerthcet kerthcet deleted the bug/shape-can-be-empty-in-scoring-stragety branch November 11, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@mikedanese mikedanese Awaiting requested review from mikedanese

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kerthcet @k8s-ci-robot @ahg-g