Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scheduler policy config #105424

Merged
merged 1 commit into from Oct 8, 2021
Merged

remove scheduler policy config #105424

merged 1 commit into from Oct 8, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Oct 3, 2021 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

Part of kubernetes/enhancements#2901

Which issue(s) this PR fixes:

Fixes #92143

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Action required: The legacy scheduler policy config is removed in v1.23, the associated flags policy-config-file, policy-configmap, policy-configmap-namespace and use-legacy-policy-config are also removed. Migrate to Component Config instead, see https://kubernetes.io/docs/reference/scheduling/config/ for details.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2901

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 3, 2021
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 3, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 3, 2021

/retest

@kerthcet kerthcet mentioned this pull request Oct 3, 2021
Closed
8 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 3, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2021
@ahg-g
Copy link
Member

ahg-g commented Oct 5, 2021

can you please rebase? also, is this still a draft?

@kerthcet
Copy link
Member Author

kerthcet commented Oct 5, 2021

can you please rebase? also, is this still a draft?

yes it's still a draft now since a related pr is merged today. I'll let you know if i finished my work.💪

@Huang-Wei
Copy link
Member

Note that this PR needs a Action Required portion. See guidance here: https://www.kubernetes.dev/docs/guide/release-notes/

Please also open a k/website PR to track the changes.

@kerthcet kerthcet force-pushed the cleanup/remove-scheduler-policy-config branch from 6b864fe to 7363cf2 Compare October 6, 2021 10:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 6, 2021

/retest

@kerthcet kerthcet force-pushed the cleanup/remove-scheduler-policy-config branch from 7363cf2 to 913af1a Compare October 7, 2021 12:59
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 7, 2021

/retest

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 7, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 7, 2021

/retest

@kerthcet kerthcet force-pushed the cleanup/remove-scheduler-policy-config branch from 066de12 to 7a69d16 Compare October 8, 2021 03:06
@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

/retest

@kerthcet kerthcet marked this pull request as ready for review October 8, 2021 07:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

PTAL @ahg-g

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g
Copy link
Member

ahg-g commented Oct 8, 2021 •
edited

Updated the description to say that it fixes #92143

@ahg-g
Copy link
Member

ahg-g commented Oct 8, 2021

Please replace the release note with the following:

Action required: The legacy scheduler policy config is removed in v1.23, the associated flags policy-config-file, policy-configmap, policy-configmap-namespace and use-legacy-policy-config are also removed. Migrate to Component Config instead, see https://kubernetes.io/docs/reference/scheduling/config/ for details.

@ahg-g
Copy link
Member

ahg-g commented Oct 8, 2021

@neolit123 can you please approve the change to test/integration/node/lifecycle_test.go

Other than that, this looks good to me.

@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

Please replace the release note with the following:

Action required: The legacy scheduler policy config is removed in v1.23, the associated flags policy-config-file, policy-configmap, policy-configmap-namespace and use-legacy-policy-config are also removed. Migrate to Component Config instead, see https://kubernetes.io/docs/reference/scheduling/config/ for details.

done :)

@ahg-g
Copy link
Member

ahg-g commented Oct 8, 2021

please squash the commits

neolit123
neolit123 reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kerthcet
remove legacy scheduler policy config, as well as associated flags po…
a6f6955 
…licy-config-file, policy-configmap, policy-configmap-namespace and use-legacy-policy-config

Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the cleanup/remove-scheduler-policy-config branch from 7a69d16 to a6f6955 Compare October 8, 2021 15:58
@ahg-g
Copy link
Member

ahg-g commented Oct 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

please squash the commits

done :)

@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

I will add a doc update then.

@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 835980a into kubernetes:master Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 8, 2021
@kerthcet kerthcet deleted the cleanup/remove-scheduler-policy-config branch September 6, 2022 02:45
@SataQiu SataQiu mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Deprecate Policy scheduling config
6 participants
@kerthcet @k8s-ci-robot @ahg-g @Huang-Wei @k8s-triage-robot @neolit123