Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nil pointer dereference #106317

Merged
merged 1 commit into from Nov 10, 2021
Merged

Fixed nil pointer dereference #106317

merged 1 commit into from Nov 10, 2021

Conversation

lauchokyip
Copy link
Member

@lauchokyip lauchokyip commented Nov 10, 2021 •
edited by k8s-ci-robot

What type of PR is this?

/kind bug

What this PR does / why we need it:

The will cause a panic because the error does not being returned when completing the Secret Object

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1134

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a panic in kubectl when creating secrets with an improper output type

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2021
@lauchokyip
Copy link
Member Author

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2021
@lauchokyip
Copy link
Member Author

/assign @eddiezane

@eddiezane
Copy link
Member

/release-note-edit

Fix a panic in kubectl when creating secrets with an improper output type

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 10, 2021
eddiezane
eddiezane approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, lauchokyip

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit ad99a59 into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@lauchokyip lauchokyip deleted the fixOutput branch November 10, 2021 23:39
k8s-ci-robot added a commit that referenced this pull request Nov 12, 2021
@k8s-ci-robot
Merge pull request #106354 from lauchokyip/automated-cherry-pick-of-#…
a797974 
…106317-upstream-release-1.21

Automated cherry pick of #106317 upstream release 1.21 - Fixed nil pointer dereference
k8s-ci-robot added a commit that referenced this pull request Nov 12, 2021
@k8s-ci-robot
Merge pull request #106356 from lauchokyip/automated-cherry-pick-of-#…
d09a985 
…106317-upstream-release-1.22

Automated cherry pick of #106317 upstream release 1.22 - Fixed nil pointer dereference
@lauchokyip lauchokyip mentioned this pull request Dec 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@dougsland dougsland Awaiting requested review from dougsland

Assignees

@eddiezane eddiezane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Improper input validation on -o flag
3 participants
@lauchokyip @eddiezane @k8s-ci-robot