Remove deprecated kubectl --dry-run values. #105327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-action-required
|
@julianvmodesto: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
/sig cli |
k8s-ci-robot
added
sig/cli
julianvmodesto
force-pushed
the
kubectl-dry-run-flag-removals
branch
from
f96f006
to
d648744
Compare
The boolean values for --dry-run have been deprecated for removal since 1.18, more than 2 releases. The default value for --dry-run with the flag set and unspecified has been deprecated for removal since 1.18, more than 2 releases. Both values are now removed in this change. Any kubectl --dry-run usage no longer accepts --dry-run=(true|false) boolean values and usage now requires that a value of (client|server|none) is specified.
julianvmodesto
force-pushed
the
kubectl-dry-run-flag-removals
branch
from
d648744
to
e0b7a85
Compare
k8s-ci-robot
added
area/test
sig/testing
|
/assign @KnVerey |
|
I'll also take a look at k8s.io docs, but I think everything ideally says --dry-run=client (at least) everywhere. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, julianvmodesto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
julianvmodesto
added a commit
to julianvmodesto/kubernetes
that referenced
this pull request
Dec 13, 2021
For 1.23, we removed the kubectl `--dry-run` empty default value (`--dry-run`) and boolean values (`--dry-run=true` and `--dry-run=false`). This change required requiring users to specify `--dry-run=client` or `--dry-run=server` due to a deprecation. This change was made in kubernetes#105327. After reconsideration, this change is not worth the churn for users. It's likely that many users rely on these values for automated and manual use cases. This change reverts kubernetes#105327 and re-introduces the values `--dry-run`, `--dry-run=true`, and `--dry-run=false`.
liggitt
pushed a commit
to liggitt/kubernetes
that referenced
this pull request
Dec 14, 2021
For 1.23, we removed the kubectl `--dry-run` empty default value (`--dry-run`) and boolean values (`--dry-run=true` and `--dry-run=false`). This change required requiring users to specify `--dry-run=client` or `--dry-run=server` due to a deprecation. This change was made in kubernetes#105327. After reconsideration, this change is not worth the churn for users. It's likely that many users rely on these values for automated and manual use cases. This change reverts kubernetes#105327 and re-introduces the values `--dry-run`, `--dry-run=true`, and `--dry-run=false`.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
The boolean values for --dry-run have been deprecated for removal since
1.18, more than 2 releases.
The default value for --dry-run with the flag set and unspecified has
been deprecated for removal since 1.18, more than 2 releases.
Both values are now removed in this change. Any kubectl --dry-run
usage no longer accepts --dry-run=(true|false) boolean values and usage
now requires that a value of (client|server|none) is specified.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: