Hi @llhuii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/cc @robscott

/ok-to-test

/assign

@llhuii thanks for catching this! Do you mind adding a release note/user-facing change text? If I'm understanding the impact correctly, I think it could be something like this:

Fixes a bug that could result in the EndpointSlice controller unnecessarily updating EndpointSlices associated with a Service that had Topology Aware Hints enabled.

/triage accepted
/priority important-soon

@llhuii thanks for catching this! Do you mind adding a release note/user-facing change text? If I'm understanding the impact correctly, I think it could be something like this:

Fixes a bug that could result in the EndpointSlice controller unnecessarily updating EndpointSlices associated with a Service that had Topology Aware Hints enabled.

Done, I have also added this information to the commit message.

@llhuii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration 528cd30 link true /test pull-kubernetes-integration
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required
Many "resource quota evaluation timed out" errors:

{"Time":"2021-09-28T01:35:34.691341433Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/quota","Test":"TestQuota","Output":"ome/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filterlatency/filterlatency.go:89 +0x46b\\nnet/http.HandlerFunc.ServeHTTP(0x4df48c0, {0x7f46546bd7a0, 0xc0087574e8}, 0xc003e023c0)\\n\\t/usr/local/go/src/net/http/server.go:2046 +0x2f\\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/filters.(*timeoutHandler).ServeHTTP.func1()\\n\\t/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/filters/timeout.go:108 +0x99\\ncreated by k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/filters.(*timeoutHandler).ServeHTTP\\n\\t/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/filters/timeout.go:94 +0x2d1\\n\" addedInfo=\"\\nlogging error output: \\\"{\\\\\\\"kind\\\\\\\":\\\\\\\"Status\\\\\\\",\\\\\\\"apiVersion\\\\\\\":\\\\\\\"v1\\\\\\\",\\\\\\\"metadata\\\\\\\":{},\\\\\\\"status\\\\\\\":\\\\\\\"Failure\\\\\\\",\\\\\\\"message\\\\\\\":\\\\\\\"Internal error occurred: resource quota evaluation timed out\\\\\\\",\\\\\\\"reason\\\\\\\""}

The actual code for this LGTM, do you mind adding some test cases that would catch this so we don't end up with a similar mistake in the future?

OK
/hold

@robscott some tests are added for getHintsByZone, PTAL.

Thanks!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llhuii, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/hold cancel