fix: consolidate logs for instance not found error #105188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
nilo19
force-pushed
the
bug/cherry-pick-794
branch
from
665368b
to
1e21fe6
Compare
k8s-ci-robot
added
the
lgtm
|
Need approval from cloud provider |
|
/retest |
k8s-ci-robot
removed
the
lgtm
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/retest |
cheftako
reviewed
Sep 29, 2021
| @@ -59,7 +59,7 @@ func TestGetVirtualMachineWithRetry(t *testing.T) { | |||
| }, | |||
| { | |||
| vmClientErr: &retry.Error{HTTPStatusCode: http.StatusInternalServerError}, | |||
| expectedErr: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: <nil>"), | |||
| expectedErr: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil)), | |||
There was a problem hiding this comment.
Not sure you want %w on something which I don't believe can be a wrapped error. Maybe just %v?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 13, 2021
…88-upstream-release-1.20 Automated cherry pick of #105188: fix: consolidate logs for instance not found error
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 13, 2021
…88-upstream-release-1.22 Automated cherry pick of #105188: fix: consolidate logs for instance not found error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: consolidate logs for instance not found error
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#789
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted
cc @feiskyer