Fixing how EndpointSlice Mirroring handles Service selector transitions #105997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/network
aojea
reviewed
Oct 29, 2021
pkg/controller/endpointslicemirroring/endpointslicemirroring_controller.go
Show resolved
Hide resolved
aojea
reviewed
Oct 29, 2021
robscott
force-pushed
the
mirroring-selector
branch
from
1a63d96
to
eee4647
Compare
robscott
force-pushed
the
mirroring-selector
branch
from
eee4647
to
794f0cb
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Nov 3, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 5, 2021
…5997-upstream-release-1.20 Automated cherry pick of #105997: Fixing how EndpointSlice Mirroring handles Service selector
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 5, 2021
…5997-release-1.22 Automated cherry pick of #105997: Fixing how EndpointSlice Mirroring handles Service selector
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 5, 2021
…5997-upstream-release-1.21 Automated cherry pick of #105997: Fixing how EndpointSlice Mirroring handles Service selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is a follow up to #105987 and #91072 that ensures that the EndpointSlice Mirroring controller will delete EndpointSlices it manages when a Service selector transitions to/from empty. Although the code changes here are fairly small, the PR is fairly large due to the integration tests it adds.
Which issue(s) this PR fixes:
Fixes #105987.
Does this PR introduce a user-facing change?
/sig network
/cc @aojea
/assign @thockin
/priority important-soon
/triage accepted