Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the default csi-proxy version installed by kube-up.sh #104426

Merged
merged 1 commit into from Aug 18, 2021
Merged

Upgrade the default csi-proxy version installed by kube-up.sh #104426

merged 1 commit into from Aug 18, 2021

Conversation

mauriciopoppe
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Upgrade the default csi-proxy version installed by kube-up.sh, the binary is already available in gke-release

gsutil ls gs://gke-release/csi-proxy/v1.0.1-gke.0
gs://gke-release/csi-proxy/v1.0.1-gke.0/csi-proxy.exe
gs://gke-release/csi-proxy/v1.0.1-gke.0/csi-proxy.exe.sig
gs://gke-release/csi-proxy/v1.0.1-gke.0/notices.tar.gz
gs://gke-release/csi-proxy/v1.0.1-gke.0/notices.tar.gz.sig

Does this PR introduce a user-facing change?

kube-up.sh installs csi-proxy v1.0.1-gke.0

/cc @jingxu97 @pjh @ddebroy @jsturtevant

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2021
@mauriciopoppe
Copy link
Member Author

/sig storage
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 17, 2021
@mauriciopoppe
Copy link
Member Author

/assign @vishh

@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@jingxu97
Copy link
Contributor

/assign @yujuhong

@jingxu97
Copy link
Contributor

/assign @pjh

@marosset marosset added this to In Progress (v1.23) in SIG-Windows Aug 18, 2021
@pjh
Copy link
Contributor

pjh commented Aug 18, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 18, 2021
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2021
@pjh
Copy link
Contributor

pjh commented Aug 18, 2021

/lgtm
/approve

@yujuhong
Copy link
Contributor

/approve

Would this get tested by any of the presubmits?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, mauriciopoppe, pjh, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@jingxu97
Copy link
Contributor

/approve

Would this get tested by any of the presubmits?

No, presubmit will only test new csiproxy version after this change is merged.
So currently it is manual testing.

@jingxu97 jingxu97 added this to the v1.23 milestone Aug 18, 2021
@mauriciopoppe
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit 9d38c64 into kubernetes:master Aug 18, 2021
SIG-Windows automation moved this from In Progress (v1.23) to Done (v1.23) Aug 18, 2021
@mauriciopoppe mauriciopoppe deleted the update-csi-proxy-version branch October 5, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@pjh pjh Awaiting requested review from pjh

Assignees

@pjh pjh

@vishh vishh

@yujuhong yujuhong

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mauriciopoppe @jingxu97 @pjh @yujuhong @k8s-ci-robot @vishh