Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #107900: Add an e2e test for updating a static pod while it #107931

Merged
merged 2 commits into from Feb 23, 2022
Merged

Automated cherry pick of #107900: Add an e2e test for updating a static pod while it #107931

merged 2 commits into from Feb 23, 2022

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Feb 3, 2022 •
edited by liggitt

Cherry pick of #107900 on release-1.23.

#107900: Add an e2e test for updating a static pod while it

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.22 regression where a static pod that is rapidly updated was failing to start until the Kubelet was restarted.

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2022
@gjkim42 gjkim42 mentioned this pull request Feb 3, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 3, 2022
@gjkim42
Copy link
Member

gjkim42 commented Feb 7, 2022

/lgtm
/triage accepted
/assign @smarterclayton
/cc @ehashman

/priority critical-urgent
Since static pod updates are broken.

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@gjkim42
Copy link
Member

gjkim42 commented Feb 7, 2022

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 7, 2022
@rphillips
Copy link
Member Author

rphillips commented Feb 7, 2022 •
edited

Unless there are any objections, we plan on merging this on Friday, February 11.

Edit: We would like to get some soak time on master.

@matthyx
Copy link
Contributor

matthyx commented Feb 8, 2022

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from matthyx February 8, 2022 06:13
ehashman
ehashman reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I checked over our testgrids to ensure there are no regressions introduced by this patch. From what I can see, the new e2e has never flaked, the unit test changes have not flaked, and there have been no reported static pod issues since merge. I think this is important to backport so we don't regress the point releases of 1.22/1.23.

@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Feb 11, 2022
@gjkim42 gjkim42 mentioned this pull request Feb 17, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@rphillips
Copy link
Member Author

cc @kubernetes/release-managers

saschagrunert
saschagrunert approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rphillips, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Member Author

/retest-required

1 similar comment
@rphillips
Copy link
Member Author

/retest-required

@gjkim42 @rphillips
Add an e2e test for updating a static pod while it restarts
33863be
@gjkim42 @rphillips
kubelet: Clean up a static pod that has been terminated before starting
60cd43c 
- Allow a podWorker to start if it is blocked by a pod that has been
  terminated before starting
- When a pod can't start AND has already been terminated, exit cleanly
- Add a unit test that exercises race conditions in pod workers
@rphillips rphillips force-pushed the automated-cherry-pick-of-#107900-upstream-release-1.23 branch from 1e701c3 to 60cd43c Compare February 23, 2022 18:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@rphillips
Copy link
Member Author

rebased to latest 1.23

@matthyx
Copy link
Contributor

matthyx commented Feb 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit b17109e into kubernetes:release-1.23 Feb 23, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 23, 2022
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@saschagrunert saschagrunert

@smarterclayton smarterclayton

@ehashman ehashman

@gjkim42 gjkim42

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rphillips @gjkim42 @matthyx @k8s-ci-robot @mrunalp @saschagrunert @ehashman @liggitt @smarterclayton