Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not delete the lb that does not exist #105777

Merged
merged 1 commit into from Nov 1, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Oct 20, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: do not delete the lb that does not exist

Which issue(s) this PR fixes:

Fixes #
Ref: kubernetes-sigs/cloud-provider-azure#860

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: do not delete the lb that does not exist

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/priority critical-urgent
/triage accepted
/sig cloud-provider
/area provider/azure
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider area/cloudprovider labels Oct 20, 2021
@nilo19
Copy link
Member Author

nilo19 commented Oct 20, 2021

/retest

2 similar comments
@nilo19
Copy link
Member Author

nilo19 commented Oct 21, 2021

/retest

@nilo19
Copy link
Member Author

nilo19 commented Oct 22, 2021

/retest

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2021
@nilo19
Copy link
Member Author

nilo19 commented Oct 25, 2021

/assign @cheftako @andrewsykim

@nilo19
Copy link
Member Author

nilo19 commented Oct 28, 2021

kindly ping @cheftako @andrewsykim for approval

@cheftako
Copy link
Member

cheftako commented Nov 1, 2021

fix: do not delete the lb that does not exist
I think this should read "fix: do not call delete for a lb that does not exist"

@cheftako
Copy link
Member

cheftako commented Nov 1, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit b403ed8 into kubernetes:master Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 1, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-860 branch November 2, 2021 01:36
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
…77-upstream-release-1.20

Automated cherry pick of #105777: fix: do not delete the lb that does not exist
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
…77-upstream-release-1.21

Automated cherry pick of #105777: fix: do not delete the lb that does not exist
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2022
…77-upstream-release-1.22

Automated cherry pick of #105777: fix: do not delete the lb that does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants